Repository navigation
dbserver: answer other-type Display, Play and Delivery song info as rekordbox does - #90
Merged
Merged
Conversation
…ekordbox does For a context track type other than 0x01, rekordbox answers Display (0x2002), Play (0x2102) and Delivery (0x2602) song info with a normal 0x4000 header whose total is 0xffffffff and no rows. Every link-spec golden for these kinds shows that, with or without the requesting player's status, and none shows the menu-unavailable error (0x4003) we sent since #81; that error is right only for 0x2202-0x2502. Decks browsing Vynull send type 0x01, so they're unaffected. Song-info album rows (TRACK INFO and Delivery Info) now leave argument 8 at 0, as rekordbox's do; only ALBUM menu rows repeat the album ID there as the artwork handle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
#81 gave the song-information requests rekordbox's per-track-type handling, but got three of them wrong. For a context track type other than
0x01, rekordbox answers Display (0x2002), Play (0x2102) and Delivery (0x2602) song info with a normal0x4000header whose total is0xffffffff, and no rows. We sent the menu-unavailable error (0x4003) instead.This doesn't depend on the requesting player's status, as I had first assumed. Every link-spec golden for these three kinds with another track type (138 cases, with and without player status) shows the
0xffffffffheader, and none shows0x4003. The menu-unavailable error is right only for0x2202to0x2502, which keep it.0xffffffffheader. Decks browsing Vynull send type0x01, so they're unaffected.The #81 rule test is updated to rekordbox's behaviour.
Conformance against rekordbox 7.2.19: 159 more cases match exactly and none stop matching (2,422 to 2,581 of 4,250); 138 more match on outcome, total and row count. Each Display, Play and class-2 status suite gains its six or seven other-type cases,
context-analysis-track-typesgains 19, and the album row fix completes Delivery cases in the sibling and boundary suites.Hardware testing
Checklist
go build ./...,go vet ./..., andgo test ./...passgofmt -l .is cleanGPL-3.0-or-later)