Skip to content

fix: complete tag arguments inside auto-closed parentheses - #251

Merged
vycdev merged 2 commits into
vycdev:developfrom
vycdev2:fix/tag-argument-autoclose
Oct 14, 2026
Merged

vycdev merged 2 commits into
vycdev:developfrom
vycdev2:fix/tag-argument-autoclose

Conversation

@vycdev2

@vycdev2 vycdev2 commented Oct 5, 2026

Copy link
Copy Markdown

Summary

  • Offer known tag-argument completions when the cursor is before an editor-inserted closing parenthesis.
  • Include the existing closing parenthesis in the completion replacement range, avoiding duplicates.
  • Cover the prefix helper and the completion provider path; document the user-visible fix.

Verification

  • Regression test on unchanged behavior: failed as expected because completion was suppressed before ).
  • npm test — passed (416 tests).
  • npm run compile — passed.
  • npm run format:check — passed after formatting the new test; npm run typecheck — passed.
  • git diff --check upstream/develop...HEAD — passed.

Risk

  • Low: only tag-argument completion range when the next character is ) changes. Dependency ID completion still has separate handling.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

@vycdev
vycdev merged commit 6b82f7b into vycdev:develop Oct 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants