Skip to content

fix: reject invalid ISO estimate dates - #248

Merged
vycdev merged 2 commits into
vycdev:developfrom
vycdev2:fix/reject-invalid-estimate-date
Oct 14, 2026
Merged

vycdev merged 2 commits into
vycdev:developfrom
vycdev2:fix/reject-invalid-estimate-date

Conversation

@vycdev2

@vycdev2 vycdev2 commented Oct 3, 2026

Copy link
Copy Markdown

Summary

  • Reject impossible ISO calendar dates in time estimates instead of accepting Sugar's rollover to another month.
  • Cover invalid dates with and without a time, plus a valid leap day.
  • Update the unreleased changelog.

Verification

  • node -r ts-node/register ./node_modules/mocha/bin/mocha.js test/time.spec.ts --grep 'rejects invalid ISO calendar' — passed (1 passing; failed on untouched behavior before fix).
  • npm test — passed (416 passing).
  • npm run compile — passed.
  • npm run typecheck — passed.
  • npm run format:check — passed.
  • git diff --check — passed.

Risk

  • Low; only rejects strictly shaped ISO date strings with invalid calendar dates. Other natural-language estimates are unchanged.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

@vycdev
vycdev merged commit cd27312 into vycdev:develop Oct 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants