Skip to content

fix: skip false embedded scan candidates with optional markers - #245

Merged
vycdev merged 4 commits into
vycdev:developfrom
vycdev2:fix/embedded-precheck-marker
Oct 14, 2026
Merged

vycdev merged 4 commits into
vycdev:developfrom
vycdev2:fix/embedded-precheck-marker

Conversation

@vycdev2

@vycdev2 vycdev2 commented Sep 29, 2026

Copy link
Copy Markdown

Summary

  • Require the configured embedded-todo marker capture in the JavaScript provider's scan pre-check, so optional/empty regex matches do not send unrelated files through full parsing.
  • Add regressions for an unmatched optional marker and an empty alternative before a real marker.

Verification

  • npm run check — passed: typecheck, 417 tests, webpack compile, and Prettier.
  • git diff --check — passed.

Risk

  • Low: candidate detection now uses the same match validation as the existing parser, only after the fast regex pre-check succeeds.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

@vycdev
vycdev merged commit 1848448 into vycdev:develop Oct 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants