Repository navigation
Update AWS S3 config, Docker setup, and add new GET endpoints - #65
Merged
Merged
Conversation
Add new GET endpoints to officers controller and service
vthish
added a commit
that referenced
this pull request
Jun 27, 2026
Update AWS S3 config, Docker setup, and add new GET endpoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant backend improvements, new features, and infrastructure changes to the project. The main themes include enhancements to the fines and license modules, improved AWS S3 integration for file uploads, updates to deployment and Docker configuration, and the addition of new endpoints and data fields. These changes collectively improve system maintainability, add new administrative capabilities, and enable secure file uploads.
Backend Features and Enhancements
fines.controller.tsfor DMT (Department of Motor Traffic) to retrieve all fines and problematic licenses, and to toggle the active status of an offense instead of deleting it. [1] [2]license.service.tsand an endpoint inlicense.controller.tsto generate signed upload URLs, leveraging AWS SDK and configuration via environment variables. [1] [2]FinesServicewith methods for toggling offense status, retrieving all fines and problematic licenses for DMT, and improved handling of bulk payments and revenue calculation. [1] [2] [3]officers.controller.tsfor police admins to list all divisions and divisional heads.Infrastructure and Configuration
.github/workflows/depoly.yml) to usegit fetchandgit resetfor safer, more consistent deployments, and improved Docker Compose commands for backend builds.node:20-slim, addedopensslinstallation, switched tonpm run buildbefore starting, and adjusted the default command for better compatibility and performance.Data Model and Dependency Updates
is_Activeboolean field to theOffence_Categorymodel in Prisma for soft-deactivation of offenses.package.json, and integratedConfigModuleand dotenv initialization in the application. [1] [2] [3] [4] [5]Minor Improvements and Refactoring
fines.service.tsandlicense.service.ts, including more robust revenue calculations and unique user data handling. [1] [2] [3]These changes collectively enhance the backend's capabilities, security, and maintainability, while introducing new features for both end-users and administrators.