Repository navigation
Include the BottomUpChildIter<PolyNf> specialization in Polynomial.hpp - #1014
Merged
Merged
Conversation
PolyNf::SubtermIter holds a Stack<BottomUpChildIter<PolyNf>>, but Polynomial.hpp only included the primary template (BottomUpEvaluation.hpp). A TU that destroys a SubtermIter without including PolynomialBottomUpEvaluation.hpp itself (e.g. ALASCA/VariableElimination.cpp) instantiated ~Stack with the empty primary template: an ODR violation that frees the stack buffer with a wrong (too small) size. Reproducer: GCC LTO build warns Kernel/PolynomialBottomUpEvaluation.hpp:26:8: warning: type 'struct BottomUpChildIter' violates the C++ One Definition Rule [-Wodr] and `c++ -std=c++17 -I. -E Inferences/ALASCA/VariableElimination.cpp | grep -c PolynomialBottomUpChildIter` printed 0 before this commit. Co-Authored-By: Claude Opus 5.5 <[email protected]>
quickbeam123
added this pull request to stack #1016
October 9, 2026 17:40
MichaelRawson
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PolyNf::SubtermIterholds aStack<BottomUpChildIter<PolyNf>>, butPolynomial.hpponly included the primary template (BottomUpEvaluation.hpp). A TU that destroys aSubtermIterwithout includingPolynomialBottomUpEvaluation.hppitself (e.g.ALASCA/VariableElimination.cpp) instantiated~Stackwith the empty primary template: an ODR violation that frees the stack buffer with a wrong (too small) size.Reproducer: GCC LTO build warns
Kernel/PolynomialBottomUpEvaluation.hpp:26:8: warning: type 'structBottomUpChildIter' violates the C++ One Definition Rule [-Wodr]
and
c++ -std=c++17 -I. -E Inferences/ALASCA/VariableElimination.cpp | grep -c PolynomialBottomUpChildIterprinted 0 before this commit.