Repository navigation
fix(slice): reject slicer warnings in strict mode - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slice --strictcould exit 0 and publish a 3MF even when Studio reported floating regions. It now rejects slicer warnings with exit 11 before publishing new output files. JSON errors include the warning text and slicer log path; default slicing keeps its existing warning summary.Verified with
make ci, regression tests, and Studio 02.08.02.61: a warning-bearing 3MF was rejected, a clean STL was accepted, and default warning behavior was preserved. Independent review: approve.