Repository navigation
Dock terminal lobby: void redesign, with settings, keybindings and the welcome inside the terminal - #587
Open
Jackriip wants to merge 122 commits into
Open
Dock terminal lobby: void redesign, with settings, keybindings and the welcome inside the terminal#587Jackriip wants to merge 122 commits into
Jackriip wants to merge 122 commits into
Conversation
A pixel-drawn mark (two-tone V through a black disc, orbit ring, moon and glint) with a small component that draws it at rest with the ring turning.
Clips are fetched and decoded once and every play starts a fresh source. The key clicks move onto it unchanged. Adds an input lock so a screen drawn over the terminal can own the keyboard.
The tube powers on, the Voidcrew symbol assembles, the name types out, a bar fills and a LOGIN button waits for the player, with new start-up sounds. It plays once per connection: the terminal remembers LOGIN for as long as the client stays connected, so a return to the lobby mid-round goes straight to the terminal. The lobby takes no input until LOGIN. Without sound it plays silent, and if it cannot draw it steps aside.
… CREWS list as blocks and rows
# Conflicts: # tgui/packages/voidcrew_tgui/interfaces/LobbyTerminal/index.tsx
The CREWS list no longer carries who is aboard. crew_open and crew_close tell the server which record is open, and only that ship's roster (names and captains) goes out. Ships carry mine for the player's own crew, memos are cut to 260 characters, a second SIGN ON while a join is under way says so, and the port-full notice drops the queue number the JOIN key shows.
… boxes The menu is back: READY or JOIN with its queue place, OBSERVE, CHARACTER with the character's name, the utility items and the station name, or a key bar with a MENU list on small panes. CHARACTER is no longer a tab. OBSERVE asks in the terminal with STAY focused. Notices sit under the box, wrap to two lines and clear themselves. Before the round the CHARACTER file opens once. The arrow keys return from the menu to the last main item, and PageUp/PageDown reach the newest pager.
Sends the station name, the respawn rule, the character's name and whether a queued player may join now. observe_confirm observes without the native box, dismiss only clears the notice it was sent for, polls are checked again after the poll window opens, and the port-full notice drops its number (the JOIN key shows it).
The record replaces the CREWS list in the same box: class and aboard, DOORS CREW ONLY, the memo, berths as solid rows with SIGN ON keys beside the names aboard, BACK and a ship stepper in the tab row. Berths page instead of hiding behind a dead +N MORE. Locked, applied, full, rejoin, code lockout, barred jobs and a join under way each have their state; countdowns tick in the page. Compact list rows spread to fill the page.
…anel CharFrame draws the CHARACTER box, the ID column (viewscreen, uniform row, a list per screen), the crumbs and the species dialog, and routes level-2 screens (openSub). ROLES, TRAITS and KIT still run their old editors inside the new frame. term.tsx gains Slab on/muted, Bar and a restyled Swatch.
The housing data sends blocked and why in place of the denial text, a sent request raises no notice, Nobody's home drops the outpost name, and a second MOVE IN while a move-in is under way keeps the CONFIRMED box.
Adds the hook file that joins ship saves to the dock terminal: one card per slot, a save that returns the player to their own crew skips the leave-crew question, launch() takes the terminal's crew answer, and the load runs in line under the join lock. LOAD refuses slots past the last, says what it is preparing, and a refused load returns to the shipyard with the reason.
When every berth fits on one page, the rows share the column (pitch up to 3.5 rows); rows 2.25 rows or taller take the larger title and a 2-row SIGN ON key. A locked crew's open counts stay in accent.
…og, Slab on, Well, class columns)
# Conflicts: # voidcrew/modules/unit_tests/_unit_tests.dm
…l, even picker columns Species rows stretch into the room the longest description leaves, colour bars thicken before the swatch grows, and a one-page two-column picker splits its list evenly. Keys with no catalog entry show read-only.
…e kit, kit name refusal notice
- Cap keys centre their label to the half cell, clear of the left border. - A lit menu key (CHARACTER while open) fills dim violet; focus keeps the bright fill and glow. - The crew record, crews list and housing page with the shared usePager helper. - Tall berth rows draw the open count at 1.25x to match the title. - A screen the server picks mounts the tab row again so its first-focus claim runs; on HOUSING the open tab is the stand-in when no key is live.
…e a bill higher than shown, keep the confirmation on a second press
…nd missing-picture note
…cus, and clears when neither is on a row; a row taking the focus leaves the search field
…shown page; unused settings exports removed
…tch up to 4, half-row gaps)
The floor tile's ramp moves from a near-grey violet to a clear violet of the same lightness, so the viewscreen belongs to the purple terminal while the character still reads against it.
…and inert StepKeys in CharFrame.tsx draws a row's < and > keys and takes the ends of a range; the arrow that can do nothing is a dead key, as the pagers draw theirs.
…and > Rows that cycle a value draw the same live mouse arrows as BODY's rows when the value has two or more choices. TRAITS option values cut at ten to make room.
…part A list that fits one column whole is drawn in one column, its rows grown to 2.25 and a quarter row apart when there is room, so a list that ends early reads as whole. Long and paged lists are unchanged.
…cter name, not on it
…ow lands on the open tab A tab was only clickable on its word, and its focus ring hugged the word (cut by the open tab's band). The whole block is now the target and the ring frames it. Moving up from a screen landed on the tab nearest the middle and switched to it (Up from the first ship opened HOUSING); it now lands on the open tab. Shared: Hit passes on tab and the new optional entry flag; nav gains FocusOpts.entry. No other caller sets either.
…ened it STAY or Escape on LEAVE CREW left the focus on the item nearest the dialog's key (the SHIPYARD tab). A focus scope now remembers the item the player had focused when it opened and returns the focus there when it closes, if that item is still on screen. The waiting first-focus claim is kept for dialogs that opened before the player focused anything (WELCOME).
Their Escape handlers now sit inside the dialog's own focus scope, as WELCOME, OBSERVE and CONFIRMED do, so a screen under the box can never take Escape first. With the species box open over CHARACTER, Escape left CHARACTER instead of answering CANCEL.
ColorEntry's component (CHARACTER and SETTINGS use CharPickers' ColourPanel) was never mounted; with it go Panel, Frame, LegacyField, lpad, LEGACY_TOP, LEGACY_NARROW and the old field CSS, which nothing else used.
ArrowRight from a category in SETTINGS or KEYS, a BODY group or a KIT category went to the geometrically nearest row, often the third or the last. A FocusGroup now marks a block that is entered as one: a sideways move into it lands on its entry item (the open category) or else on its first item. Left from the rows in SETTINGS and KEYS lands on the open category, as Escape does.
CONTACTING THE YARD, NO BERTHS OPEN and APPLICATION SENT now read like the other one-sentence states beside them (NO HULLS ON THE SHELF., FETCHING YOUR FILE., NO MATCH.).
…d row's description A stepped SETTINGS row now draws StepKeys, the two cap keys at the row's right end that BODY, KIT and AGE use, instead of bare < > glyphs around the value; the end of a number's range draws its key dead as before. The values start at column 44 like the KEYS values. Which choices open the list picker on Enter is unchanged. While a number or text is being typed the description strip keeps the typed row's description instead of going blank.
Before the yard's records arrive the box drew three blank slabs with empty wells, which read as broken. It now draws one ghost block with the state, as it does when the records are offline.
HOUSING's denials and a saved ship's refusal arrive in mixed case (Still in cryo for 4 minutes and 59 seconds.) and now draw upper case like every other notice. Display only; the server text is unchanged.
The bill paged its lines with a pager only; every other paged list in the terminal also turns with the mouse wheel and PageUp/PageDown.
…s way on a short menu
# Conflicts: # voidcrew/modules/onboarding/first_time_notice.dm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The lobby's dock terminal, rebuilt in the purple "void" style. Everything a player does before a round now happens inside the terminal: joining a crew, buying and fitting a ship, housing, the character editor, game settings, keybindings and the first-time welcome. It has a start-up screen, motion and sound, and works with the keyboard, the mouse and the mouse wheel. It fits any window from 472x360 (where the side menu becomes a row of keys) up to a large pane.
Screens
The same with its sound
What players will notice
CTRL+SHIFT+NUMPAD5. Arrow keys and Delete bind under the names the game matches, so they work when bound.For the server
RULESURL https://rules.voidcrew-lrp.comis set in the repo'sconfig/config.txt. The live server's own config needs the same line, or RULES draws greyed out.Upstream files touched
code/modules/mob/dead/new_player/new_player.dm:make_me_an_observer()takes aconfirmedargument so the terminal can ask in its own box (markedVOIDCREW EDIT).config/config.txt: the rules address.