Skip to content

Instant Review filter; assistant screen keeps its own session - #71

Merged
voidReq merged 2 commits into
mainfrom
review-assistants
Oct 28, 2026
Merged

voidReq merged 2 commits into
mainfrom
review-assistants

Conversation

@voidReq

@voidReq voidReq commented Oct 28, 2026

Copy link
Copy Markdown
Owner
  • Review: the kind-of-work menu filters the list already in the page (no server request; ~10 s before, because the page first waited for earlier Approve decisions to finish writing the sheet). No list waits for pending decisions any more; the server keeps every list's jobs decidable (APP.queue).
  • Assistant screen: it keeps the session it opened on (review.key), not the slot. A session that ends, or the next one taking its slot, sends you back to Apply > Assistants with a toast (before: "No session there", or a silent switch to the new session). Taps carry the key; the server refuses one for a session no longer in that slot.
  • Tests: test_gui (no request on a kind-of-work change), test_review (slot taken over -> back to Assistants), test_homelab_app (stale key refused). Docs: GUI.md, REMOTE.md.

🤖 Generated with Claude Code

voidReq and others added 2 commits October 28, 2026 15:16
…uestions wait over chats

- Review: the kind-of-work menu picks from the list the page already has (no server trip), and no list
  waits for decisions still being written to the sheet (the server keeps every list's jobs decidable).
- An assistant's screen whose session ended goes back to Apply > Assistants with a toast.
- A run's question no longer covers an assistant's chat (or a box you type in): a toast and the bottom
  bar's "Answer its question" open it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
…on hold

A slot is reused by the next session once one ends, and the screen silently showed that new session
as if it were the same. The view now carries the session's key (review.key); a different key sends
the screen back to Apply > Assistants, and a tap with a stale key is refused by the server.
The run-question hold from the last commit is taken out (that was not what took over the screen).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@voidReq
voidReq merged commit aa02631 into main Oct 28, 2026
6 checks passed
@voidReq
voidReq deleted the review-assistants branch October 28, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant