fix(cli): include deploy error on --wait timeout - #88
Merged
Merged
Conversation
Append the deployment job error field after last status when voicethere deploy --wait times out so CLUSTER_NO_CAPACITY messages are visible during retries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
voicethere deploy --waittimed out with only(last status=queued)when the control plane already had a cluster admission error on the job.What
pollWithBackoffcan append last-job detail. Deploy--waitusesjob.error, so a timeout looks like:(last status=queued; CLUSTER_NO_CAPACITY: deploy_admission cpu_deficit=255m memory_deficit=0)Requires the matching platform change that persists
deploy_jobs.errorwhile the job is still queued.Verify
From
cli/:Verified locally (exit 0).