Repository navigation
test(rsc): run cloudflare e2e on a copy of starter-extra - #1488
Merged
Merged
Conversation
The cloudflare dev tests edited `examples/starter-extra` in place for HMR, while other specs copy that directory as their inline fixture base. A copy taken on the other worker during an edit could build with the edited source. Run the cloudflare tests on an inline fixture instead. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Match the Cloudflare plugin and wrangler versions in starter-extra. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cloudflare e2e tests ran directly on
examples/starter-extra, and their dev HMR tests edit its client, root, and css files in place before restoring them. Most other e2e specs copyexamples/starter-extraas the base for their inline fixtures. Playwright runs two workers, so a spec on the other worker could copy the example mid-edit and build a fixture with the edited source. #1480 hit the same race withexamples/starter, where it showed up as a fixture renderingClient [edit] Counter.This PR runs the Cloudflare tests on their own copy under the e2e temp directory, the same way other inline fixtures work. No test edits
examples/starter-extrain place anymore. The copy resolves packages from the shared e2e fixture package, so the Cloudflare Vite plugin and wrangler are added there.The contributing guide also told contributors to base inline fixtures on
examples/starter, which contradicts the agent guide and what nearly every existing test does. It now saysexamples/starter-extra.