Repository navigation
test(rsc): fix e2e flakes in use-cache-persistent and isolated fixture setup - #1487
Merged
Merged
Conversation
- Space out editor writes to the same file. Vite's chokidar watcher drops a `change` event within 50ms of the previous one, so a fast HMR round trip could swallow `editor.reset()` (e.g. `dev-no-ssr > client hmr`). - Wait for the `rsc:update` refetch before reloading in `use-cache-persistent`, so the reload neither aborts it (unhandled `Load failed` in WebKit) nor receives the late update before hydration (`setPayload is not a function`).
`setupIsolatedFixture` runs `pnpm i` over the network inside a `beforeAll` hook. On macOS runners installs take 16-34s, and the `react-server-dom-webpack` fixture installs twice, so the hook kept hitting the default 30s timeout.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
The editor write-spacing fix moves to its own PR, which makes the editor API async instead of sleeping synchronously. Co-Authored-By: Claude Opus 5.5 <[email protected]>
hi-ogawa
changed the title
hi-ogawa
marked this pull request as ready for review
October 5, 2026 08:42
hi-ogawa
added a commit
to james-elicx/vite-plugin-react
that referenced
this pull request
Oct 5, 2026
…-entry Take main's e2e/fixture.ts and e2e/use-cache-persistent.test.ts. The e2e deflake fixes from this PR landed separately in vitejs#1487, with the write spacing moved to vitejs#1489.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainnightlies (react-server-dom-webpack › dev › basic,beforeAllhook timeout): 2026-10-05 macos webkit, 2026-10-02 macos chromium, 2026-09-30 macos chromiumTwo e2e flakes, unrelated to the facade entry fix in #1480, so they can land independently.
The
use-cache-persistentdev test reloaded the page while the RSC refetch triggered by a server edit was still in flight. WebKit reported the aborted request as an unhandledTypeError: Load failed, and a late update could also reach the reloaded page before it hydrated (setPayload is not a function). The test now waits for that refetch to finish before reloading. Seen on #1480 CI asLoad failedon macos webkit andsetPayload is not a functionon macos chromium.Isolated fixtures run
pnpm iover the network, which took 16-34s on macOS runners and pushedbeforeAllpast the default 30s hook timeout, especially for thereact-server-dom-webpackfixture that installs twice. The setup now allows 60s.