perf: general optimizations

[xaevik]

No description provided.

[Copilot]

Copilot review overview

🟡 Changes recommended

Moderate findings remain for the untested no-GMP fallback, radix coupling, and contradictory AGENTS.md guidance.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 2

Open (3)

• Add CI coverage for the pure-PHP conversion fallback · New
• Align benchmark inputs and targets with reported table · New
• Move benchmark property below setUp() · New

What changed in this PR

Optimizes CUID2 generation by converting raw SHA3-512 digests directly to base36, with expanded tests, benchmarks, and documentation.

Changes:

• Adds limb-based binary-to-base36 conversion with GMP and pure-PHP paths.
• Routes raw digest conversion through optimized logic.
• Expands tests and benchmarks; updates documentation and guidance.

File	Summary
tests/​UtilsTest.php	Adds byte-conversion coverage.
tests/​FingerprintTest.php	Reorganizes and extends fingerprint tests.
tests/​Cuid2Test.php	Expands generation and validation tests.
tests/​CounterTest.php	Reorganizes counter tests.
tests/​benchmark/​ValidationBench.php	Reorganizes validation benchmarks.
tests/​benchmark/​UtilsBench.php	Adds conversion benchmarks. Nit (1 vote): use a neutral label instead of fast-path-7-bytes.
tests/​benchmark/​SingletonBench.php	Reorganizes singleton benchmarks.
tests/​benchmark/​Cuid2Bench.php	Adds generation and serialization benchmarks. Nit (2 votes): move $cuid below setUp().
src/​Utils.php	Adds optimized byte/limb conversion. Moderate (1 vote): derive the radix from BASE36_DIGITS_PER_PASS or enforce an invariant.
src/​Fingerprint.php	Reorders singleton methods.
src/​Cuid2.php	Uses GMP or pure-PHP raw-digest conversion. Moderate (3 votes): add coverage for the no-GMP fallback path.
src/​Counter.php	Reorders singleton methods.
README.md	Documents conversion and performance. Nits: align benchmark inputs with the table (2 votes) and correct the inconsistent documented range (1 vote).
ARCHITECTURE.md	Documents the updated conversion paths.
AGENTS.md	Updates repository guidance. Moderate (1 vote): clarify whether the cache restriction applies to internal caches.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

Three moderate findings and one benchmark-label nit remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2

Open (2)

• Test does not verify the GMP fallback path · New
• Avoid adding mutable process-scoped static state · New

Resolved since last review (3)

• Add CI coverage for the pure-PHP conversion fallback
• Move benchmark property below setUp()
• Align benchmark inputs and targets with reported table

[Copilot]

Copilot review overview

🟡 Changes recommended

Three unresolved moderate findings concern benchmark overhead, missing fixed-digest coverage, and unsafe getenv() handling.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

• Guard false getenv result before calling array_keys · New

Resolved since last review (2)

• Avoid adding mutable process-scoped static state
• Test does not verify the GMP fallback path

Previously missed (1)

In code that hasn't changed since last review

Add fixed-digest assertion for GMP conversion correctness

src/​Cuid2.php:246

The new GMP conversion branch is exercised by ordinary generation tests, but no test asserts its result for a fixed digest. An endian or word-order error here would still produce valid-looking, correctly sized CUIDs and pass the current assertions; add a fixed-digest equality check against the independently tested Utils::bytesToBase36() path.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Copilot review overview

🔵 Needs a closer look

Moderate GMP-path coverage and the listed style and test-order fixes remain unresolved.

Review effort: Lite
Findings: None

Resolved since last review (1)

• Guard false getenv result before calling array_keys

Previously missed (1)

In code that hasn't changed since last review

Compare GMP output with forced fallback for fixed digest

tests/​Cuid2Test.php:108

This test disables GMP before invoking convert(), while the other CUID tests assert only format or length. No test now verifies that the new GMP import produces the same value as the pure-PHP path for one digest, so a byte-order or flag regression could pass; capture the GMP result first and compare it with the forced fallback.