Repository navigation
Conversation
Picking a saved projection from the library had no visible effect: - The browse dialog stayed open after picking an item, so it looked like nothing happened. Close it, like the Cancel button does. - The projection list replaced the edited projection by looking it up by the id of the *newly picked* projection, which never matched any item in the list, so the picked projection was silently dropped. Replace by position instead. Consumer sessions were unaffected because their library browser lives in the sidebar and navigates instead of editing a list in place. Also add test ids needed to drive the library browser from e2e tests. Fixes visortelle#339
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Picking a saved projection from the Library had no visible effect (#339):
projection, which never matched anything — so the pick was silently dropped.
Consumer sessions were unaffected: their library browser lives in the sidebar and
navigates, instead of editing a list in place.
What changed
lib-panel-<itemType>andlib-savetest ids — a projection, the projectionlist and a projection's target each own a library panel, so tests must tell them apart.
Test plan
Added
CS-33(CsProjectionLibrarySpec): saves a projection to the library, adds asecond one and applies the saved projection to it — their ids differ, which is
exactly what the old lookup could not handle. Asserts the dialog closes, the second
projection takes the saved label, and the first is untouched.
Note: an earlier version re-picked the same projection and passed even with the bug,
since the ids happened to match. Verified the current test fails without the fix.
LibrarySelectSpec,LibraryBrowseSpec,LibraryCrudSpec— 14 tests, all green.Fixes #339