Repository navigation
feat(ui): VM tags on the redesigned console (rebase of #256) - #260
Merged
Merged
Conversation
Add a Tags field to DeployVMInput and UpdateVMInput (nil means untouched, a non-nil slice including an empty one replaces the tags), carry the tags through DeployVM and UpdateVM, and persist them to Instance.spec.tags via the store mapping. MergePlatformVM no longer resurrects cleared tags and the legacy hypervisor deploy path forwards them too.
UpdateVM discarded the GetVM fallback result and re-queried the store, which could return nil for legacy/KubeVirt-only VMs without an Instance CR, panicking on the field access below. Use the GetVM result and add a nil guard, with a regression test.
Show API tags in the VM list, seed the edit form with existing tags and render them as removable pills (Enter/comma to add, Backspace to drop the last). Extract a reusable TagsInput and reuse it in the deploy wizard, fixing creation so more than one tag can be entered (the old input stripped the comma on every keystroke). Add pt/en strings and a unit test for mergeTags.
Matheus-Thurler
requested review from
RodrigoGoncalves-dev and
wesleip
as code owners
October 16, 2026 13:22
wesleip
approved these changes
Oct 16, 2026
1 of 2 tasks
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maincom o redesign da UI (feat(ui): redesign console with new shell, pages and tokens #259).TagsInputadaptados ao novo layout (KeyValueList, tokens novos). Backend Go sem mudanças.main. Depende de feat(api): add tags to Instance, VPC, Network and SecurityGroup specs operator#74 (campospec.tagsnos CRDs) e da sincronia dos CRDs no chart.Test plan
go build ./... && go test ./...npm run buildenpm test(32 testes)