Repository navigation
Add Venice support to snphost - #203
Draft
DGonzalezVillal wants to merge 2 commits into
Draft
DGonzalezVillal wants to merge 2 commits into
DGonzalezVillal wants to merge 2 commits into
Conversation
DGonzalezVillal
force-pushed
the
venice
branch
from
November 6, 2026 22:38
e4ba49f to
c3a9f28
Compare
amd-aliem
reviewed
Nov 9, 2026
| snphost config set --tee TEE --snp-fw SNP-FW --mask-chip MASK-CHIP [--bootloader BOOTLOADER] [--microcode MICROCODE] [--fmc FMC] | ||
| ``` | ||
|
|
||
| `--tee`, `--snp-fw`, and `--mask-chip` are required on every generation. `--bootloader` and `--microcode` are required on Milan, Genoa, Bergamo, Siena, and Turin, and are not used on Venice. `--fmc` is required on Turin and Venice, and is not used on older generations. |
Collaborator
There was a problem hiding this comment.
Getting a bit long with the permutations, I wonder if it'd be more clear to put a table here, or something more structured (a list?). The later section that goes generation-by-generation is great, but people may not scroll down that far.
| | tee | snp-fw | mask-chip | bootloader | microcode | fmc |
| milan, genoa, bergamo, siena | y | y | y | y | y | |
| turin | y | y | y | y | y | y |
| venice | y | y | y | | | y |
Or
Signed-off-by: DGonzalezVillal <[email protected]>
The positional TCB arguments cannot represent fields that Venice no longer reports. Signed-off-by: DGonzalezVillal <[email protected]>
DGonzalezVillal
force-pushed
the
venice
branch
from
November 9, 2026 21:46
c3a9f28 to
1cc65aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labeled as Draft until : virtee/sev#407 is merged a new release is cut for SEV.
Want to get thoughts on config since this will break it's flags, maybe there is a better way to organize config