Repository navigation
Conversation
brongan
force-pushed
the
fix-launch-update-aliasing
branch
2 times, most recently
from
November 12, 2026 19:30
87fa3df to
0843195
Compare
brongan
changed the title
brongan
force-pushed
the
fix-launch-update-aliasing
branch
from
November 12, 2026 19:37
0843195 to
5dec1db
Compare
brongan
changed the title
Pass the launch update request to the kernel as a mutable reference. Verify that the returned memory range stays within the input buffer. Reject ranges outside the buffer with an error. The kernel writes back into the launch update request through a shared reference, which causes undefined behavior. The code then used the range returned by the kernel without a bounds check. Signed-off-by: Brennan Tracy <[email protected]>
brongan
force-pushed
the
fix-launch-update-aliasing
branch
from
November 13, 2026 19:13
5dec1db to
5ed814f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the launch update request to the kernel as a mutable reference. Verify that the returned memory range stays within the input buffer. Reject ranges outside the buffer with an error.
The kernel writes back into the launch update request through a shared reference, which causes undefined behavior. The code then used the range returned by the kernel without a bounds check.