Repository navigation
Conversation
brongan
force-pushed
the
fix-cert-table-bounds
branch
from
November 11, 2026 19:12
f6b37f0 to
c0b16c5
Compare
brongan
force-pushed
the
fix-cert-table-bounds
branch
2 times, most recently
from
November 12, 2026 19:30
ae6d4c4 to
8a792f1
Compare
brongan
changed the title
brongan
force-pushed
the
fix-cert-table-bounds
branch
from
November 12, 2026 19:37
8a792f1 to
5ec17e4
Compare
Check the firmware error status after each report request. Allocate a larger buffer and retry when the firmware needs more space. Confirm that a certificate buffer exists before reading its entries. Parse the certificate table from the allocated buffer. Some kernels do not fail the ioctl when the certificate buffer is too small. On those kernels, the code read the certificate table from an invalid placeholder address. Signed-off-by: Brennan Tracy <[email protected]>
Parse certificate tables from byte buffers instead of raw pointers. Check each entry offset and length against the buffer size. Return an error when an entry exceeds the buffer or when the table lacks a terminating entry. The certificate table parser trusted offsets and lengths from the input table. Malformed input caused out-of-bounds reads and panics in a safe public function. Signed-off-by: Brennan Tracy <[email protected]>
brongan
force-pushed
the
fix-cert-table-bounds
branch
from
November 13, 2026 19:13
5ec17e4 to
5876667
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse certificate tables from byte buffers instead of raw pointers. Check each entry offset and length against the buffer size. Return an error when an entry exceeds the buffer or when the table lacks a terminating entry.
The certificate table parser trusted offsets and lengths from the input table. Malformed input caused out-of-bounds reads and panics in a safe public function.