fix: harden extraction output and error handling - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extraction output is now deterministic, and failures are loud instead of silent.
#RRGGBBstrings, with only the curated attributes kept;ctermmode reads thectermattributes tableextract()validates its input and raises errors for an invalid output path, a bad colorscheme list, and failed default highlights, instead of printing and returningextract()returns the extracted data tableVCSExtractwith no arguments now falls back to all installed colorschemes{}instead of[]this is the plugin-side counterpart to vimcolorschemes/worker#95, which can then rely on always-hex output and thrown errors rather than normalizing and guarding locally.