fix(cli): run Python subprocesses in UTF-8 mode - #82
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
PASS+NOTES from an independent reviewer at head No blocking findings. I reviewed all four callers, the private raw-buffer adapter, caller limits/isolation, legacy decoding, native-path test repair and both installed observer changes. The patch adds no comments or type suppressions. Scoped lint and diff checks passed. Independent live proof:
Notes: the PR's installed-package CI job is skipped by the existing classifier, so the audited full local run supplies that evidence. The PR description can now replace its native-pending line with the successful run. Refresh against current main before landing; retain this code verdict only if the stable patch ID is unchanged, with current-head CI and mergeability rechecked. Windows 11 desktop and human PDF inspection remain separate qualification work. |
|
Root verification PASS at The independent non-author verdict is recorded above. The refreshed diff retains stable patch ID Native Windows proof passed all four Python operations at the reviewed patch. Independent review checked live before/after behavior and installed archive receipts, including 38 verification and 22 PDF cases. Current-head quality, isolation, dependency-review, PR-title and CodeQL pass. Installed-packages is skipped by the maintained CI policy; the full installed acceptance receipt was independently audited. GitHub reports CLEAN with no unresolved threads. Normal protected merge is authorized for this head only. |
Why
Python can encode piped JSON with the Windows locale while the CLI expects UTF-8. Unicode calculation metadata then causes an encoding failure or invalid JSON. Start all CLI Python operations in UTF-8 mode.
Related to #77.
Scope
runPythonProcessadapter.Verification
npm run test:packagespasses with fresh archives and a wheel, including 38 verification cases, 22 PDF cases, and generated-project browser/API/PDF/restart acceptance.