fix(demo): launch npm through Node on Windows - #81
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Independent verification: PASS+NOTES. No blocking code or scoped-comment findings. Reviewed head I did not author this PR. The old launcher failed with I inspected the exact-head Windows job. Its checkout and environment log confirm this head on Windows Server 2025, Node 24.21.0 and PowerShell 7.6.6. Eight tests passed, the POSIX signal test was intentionally skipped, and real npm reached PowerShell 5.1 and Windows 11 foreground Ctrl+C/restart remain part of later support qualification. Main advanced during review, so the owner must integrate current main, compare the patch ID, and rerun merge gates before the coordinator authorizes landing. |
|
Root verification PASS at The independent non-author reviewer recorded PASS+NOTES above. I verified the refreshed diff retains stable patch ID Exact-patch native Windows proof passed argument forwarding, environment, exit handling and a real npm child. Independent live review also verified preparation cleanup and baseline ENOENT. Current-head quality, isolation, installed-packages, dependency-review, PR-title and CodeQL pass. GitHub reports CLEAN and MERGEABLE, with no unresolved threads. Normal protected merge is authorized for this head only. |
Why
The root demo commands spawn bare
npm, which fails withENOENTon native Windows. Invoke npm's JavaScript entry through the current Node executable with an argument array and no shell.Fixes #78.
Scope
npm run devornpm run build:demo.Verification
spawnSync npm ENOENTdespite a validnpm_execpath.node node_modules/vitest/vitest.mjs run tests/integration/demo-launch.test.ts: nine tests passed on macOS with Node 24. The signal case runs on POSIX hosts.npm run typecheckpassed.npm run build:demo -- --helpforwarding passed with an explicit examples directory. The full defaultnpm run build:demoalso passed with an independently installed wheel.