fix(python): generate portable binding bytes - #80
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Independent verifier verdict: PASS+NOTESReviewed PR 80 at head I found no correctness, ownership, or test-boundary defect in the five-file patch. The implementation keeps binding generation in Live proof
Diff and comment auditThe scoped diff adds no TypeScript, lint, or Python suppressions. It adds no phase comments or workaround explanations that need removal. Notes before mergePR 80 is now behind Commands
|
|
Root verification PASS at The independent non-author review is recorded above. I fetched the refreshed branch and verified its stable patch ID remains Exact-patch native Windows proof passed binding bytes, freshness, callability and canonical reference agreement with Windows Git conversion enabled. Current-head quality, isolation, installed-packages, dependency-review, PR-title and CodeQL all pass. GitHub reports CLEAN and MERGEABLE. No unresolved review threads were found. The user authorized merging after CI/CD passes. Normal protected merge is authorized for this head only. |
Why
Windows binding generation uses native path separators and text-mode writes, which change the source closure and invalidate existing numerical references. Fixes #77.
Scope
Verification
core.autocrlf=truefrom an installed archive.core.autocrlf=trueretains the canonical closure hash and passes the original untouched reference.