Skip to content

Migrate the r2darts2 family to prediction_format: prediction_frame — deferred from #489 #492

Description

@Polichinel

Deferred from #489 / PR #491 (epic #488), where the eleven pgm r2darts2 models arrived from staging_202608 with prediction_format: "prediction_frame" and were set back to "dataframe".

Why they were set back

On staging the value was applied by one commit (2dfe6d75, "pfs", 2026-07-22) to four of them and inherited from the scaffold template by the other seven — but none got the keys the PredictionFrame contract needs (n_posterior_samples, hp regression_targets), and staging's own tests/conftest.py lists all eleven under _INCOMPLETE_PFE_MODELS ("has not completed the PredictionFrame contract migration"). development has no such skip-list; test_pfe_production_readiness.py would have failed 22 times. All 31 cm r2darts2 siblings run on "dataframe", and 13 of them passed calibration on fimbulthul on 2026-09-19 that way.

What this issue is

The actual migration, for all 42 r2darts2 models (31 cm + 11 pgm), when someone decides the r2darts2 engine is ready for the frames-native path:

  • r2darts2 0.2.x's prediction output must satisfy the PredictionFrame contract on the DataFrame → frame boundary (pipeline-core ADR-018; C-136 says the pandas-free evaluation path is "built, tested and unreachable").
  • each config: prediction_format: "prediction_frame", n_posterior_samples (point models: evaluation_mode: "point" + aggregate_method, cf. All 9 point baselines rejected by CoreConfigSniffer: evaluation_mode='point' without aggregate_method (since #220, 2026-06-27) #477), hp regression_targets.
  • test_pfe_production_readiness.py then judges them — no skip-list.
  • ADR-064's entity-coverage check exempts the PF path today (pipeline-core); check that stays true or that the PF path has its own.

Not before #490 (maturity for the 31) lands. Not part of epic #488's definition of done.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions