Repository navigation
fix(ui): lay out the viewer for phones and narrow cards - #37
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Approval required for deploying to Cloudflare Workers (Preview) for docs.
|
nekomeowww
added a commit
that referenced
this pull request
Oct 21, 2026
Bring in #37 (phone layout and narrow cards), #38 (run header leads with the score), and v0.10.2. Conflicts kept main's layout and behavior and applied the translations on top; the strings #37 and #38 added (the ETA info button, Run details) are translated in en and zh-Hans. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These are layout fixes from a pass over the viewer at 390, 820, 1024 and 1440px, using real reports (airi
tts-speech-formula).Overflow at mid widths
@[62rem]and@[65rem]). Before, they used the viewport'smdbreakpoint. With the sidebar open, a window pastmdleft the card about 300px narrower than the columns need, and the rows ran out of the card (columns reached x=1337 at 1024px).minmax(0,1fr). The d3 chart scrolls inside its own wrapper and no longer widens the card and the page.Phones
InfoButtoncomponent: a popover on desktop and a vaul drawer on phones, with the same body. It follows theScoreBadgepattern.smsize, so it fits the card.[axis=value, …]suffix that the axis columns already show (the full name is in the tooltip). Cell values no longer break at hyphens.overflow-wrap: anywhereinstead ofbreak-all).Charts
0. The axis is now 0–1.How tested
pnpm -F @vieval/ui exec vitest run: 227 passed.pnpm -F @vieval/ui typecheckand eslint on the changed files pass.🤖 Generated with Claude Code