Skip to content

fix(ui): keep the run list score inside its column #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nekomeowww merged 1 commit into from
Oct 20, 2026
Merged

fix(ui): keep the run list score inside its column #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/ui/client/src/pages/ExperimentPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,12 @@ const isPartial = (run: (typeof runs.value)[number]) => run.state !== 'running'
/**
* Grid of a run row. Wide screens: one line with select, attempt, run, duration, cases, headline score, menu (the
* header uses the same columns). Narrow screens: select, attempt, score, and menu on the first line, the run and its
* duration below the attempt, then the cases.
* duration below the attempt, then the cases. The score column fits a typical headline (`100.0% Correct and natural`);
* a longer label truncates inside it instead of spilling over the case bar.
*/
const rowGrid = [
'grid items-center gap-x-3 gap-y-1.5 grid-cols-[1rem_minmax(0,1fr)_auto_1.75rem]',
'md:(gap-x-4 grid-cols-[1rem_minmax(14rem,1.6fr)_minmax(9rem,1fr)_5rem_minmax(12rem,2fr)_8rem_1.75rem])',
'md:(gap-x-4 grid-cols-[1rem_minmax(14rem,1.6fr)_minmax(9rem,1fr)_5rem_minmax(12rem,2fr)_minmax(8rem,12rem)_1.75rem])',
]
const selected = shallowRef<string[]>([])
function duration(run: { endedAt?: string, startedAt?: string }): number | undefined {
Expand Down Expand Up @@ -171,7 +172,7 @@ watch([() => props.attempt, () => attempts.value.length], async ([attempt]) => {
<CountsBar :class="['flex-1']" :counts="expectedCounts(run)" />
<span v-if="isPartial(run)" :class="['badge state-interrupted shrink-0']" :title="`${run.counts.total} of ${run.caseTotal} expected cases ran`" data-testid="attempt-partial">{{ run.counts.total }} / {{ run.caseTotal }}</span>
</span>
<HeadlineScore :class="['relative z-1 justify-self-end max-md:(row-start-1 col-start-3)']" :result="run.headline" :definitions="run.headlineDefinitions" size="sm" align="end" />
<HeadlineScore :class="['relative z-1 justify-self-end min-w-0 max-w-full max-md:(row-start-1 col-start-3)']" :result="run.headline" :definitions="run.headlineDefinitions" size="sm" align="end" />
<!-- IdMenu renders no element of its own; the wrapper carries the grid placement. -->
<span :class="['flex max-md:(row-start-1 col-start-4)']"><IdMenu :id="run.runKey" kind="run" /></span>
</div>
Expand Down
Loading