Repository navigation
Release package 0.3.0 - #27
Conversation
The git tag and npm package follow 0.2.9. The Chrome extension stays 1.1.0. The release workflow quotes match the formatter.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f56958ad7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
npm refuses a private workspace package. The release job now writes dist/package.json without private or workspaces, and the repo root stays private.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6c467bafd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const pkg = JSON.parse(readFileSync("package.json", "utf8")); | ||
| delete pkg.private; | ||
| delete pkg.workspaces; | ||
| writeFileSync("dist/package.json", JSON.stringify(pkg, null, 2) + "\n"); |
There was a problem hiding this comment.
dev-browser
When the v0.3.0 tag runs this job, the generated manifest removes only private and workspaces, so it retains the root name browser-hand; reproducing the assembly with npm pack --dry-run identifies the archive as [email protected]. The release documentation configures trusted publishing and post-release verification for dev-browser (RELEASING.md:16-19, 97-104), so this either fails OIDC authorization or publishes the headless payload under the wrong package while dev-browser remains at 0.2.9. Generate a dedicated headless manifest with the dev-browser identity instead of copying the product-root identity.
AGENTS.md reference: AGENTS.md:L13-L17
Useful? React with 👍 / 👎.
A v* tag still opens the GitHub release. npm publish and the binary build wait until the PUBLISH_NPM repository variable is true.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1371270fd0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tag="${GITHUB_REF_NAME#v}" | ||
| pkg="$(node -p "require('./package.json').version")" | ||
| if [ "$tag" = "$pkg" ]; then | ||
| if [ "$tag" = "$pkg" ] && [ "$PUBLISH_NPM" = "true" ]; then |
There was a problem hiding this comment.
When an operator follows the upstream release procedure in RELEASING.md:78-104, they are told to push a matching version tag and then verify the npm release, but this new condition now successfully skips every build and publish unless a separate repository variable is exactly true. The first-time setup in RELEASING.md:14-28 never mentions configuring or resetting PUBLISH_NPM, so the documented procedure can finish green with only a GitHub release while dev-browser remains unpublished; update the release instructions to include this required gate and its lifecycle.
Useful? React with 👍 / 👎.
1 participant
Summary
Test plan
package.json,cli/Cargo.toml,cli/Cargo.lock, and.claude-plugin/marketplace.jsonall say 0.3.0extension/package.jsonis still 1.1.0v0.3.0on the merge commit so npm publish runs