feat(lookup): always enable path completion even if a spec isn't registered

[magnus-rattlehead]

Currently, path autocompletion doesn't work unless a spec is registered for a command. I think we shouldn't have to register a spec for a command just to get path completion. This adds the option to always complete paths

[versenilvis]

yeah you're right
but I think it's better be a default feature, not a config option (maybe you should open a new PR, idk)

also a bug, the path completion block runs before checking if a spec exists, so for commands that already have a spec (like git), it replaces the entire spec with a stub if any files match. Should be guarded with !exists:

if !exists && config.Get().Core.PathCompletion && partial != "" && !strings.HasPrefix(partial, "-") {

Also the partial redeclaration inside if !exists can be removed now (check lint to understand)

Additional: FileGenerator() is called with the full list of tokens, but partial represents only the last token. This works fine when the user is in the middle of typing a path, but it fails to handle cases like sometool arg1 (where partial is "") due to the partial != "" guard

[magnus-rattlehead]

yeah you're right but I think it's better be a default feature, not a config option (maybe you should open a new PR, idk)

also a bug, the path completion block runs before checking if a spec exists, so for commands that already have a spec (like git), it replaces the entire spec with a stub if any files match. Should be guarded with !exists:

if !exists && config.Get().Core.PathCompletion && partial != "" && !strings.HasPrefix(partial, "-") {

Also the partial redeclaration inside if !exists can be removed now (check lint to understand)

Additional: FileGenerator() is called with the full list of tokens, but partial represents only the last token. This works fine when the user is in the middle of typing a path, but it fails to handle cases like sometool arg1 (where partial is "") due to the partial != "" guard

I've updated the PR, this actually made the implementation much cleaner

[versenilvis]

change the title to conventional style so I can merge as a commit