Repository navigation
Fix leading underscores in Caliptra testbench literals - #60
Merged
gezalore merged 1 commit intoOct 13, 2026
Merged
Conversation
Same change as chipsalliance/caliptra-rtl#1439, applied to the copy imported at 0d5d4097.
Member
|
Thanks for all these fixes, keep them coming :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caliptra's
caliptra_top_tb_services.svwrites seven based literals as512'h_8FA8..., with an underscore as the first digit character. IEEE 1800-2023 5.7.1 says the underscore "shall be legal anywhere in a number except as the first character", and A.8.7 writeshex_value ::= hex_digit { _ | hex_digit }, so a tool that follows the grammar rejects the file.The text is Caliptra's own and is fixed there in chipsalliance/caliptra-rtl#1439. This applies the same change to the copy imported at
0d5d4097, where seven of the nine places exist. The values are unchanged.