Repository navigation
Silence Ruby 4 plate regex warnings - #4
Merged
Merged
Conversation
The README drive-by in the previous commit replaced an accurate ~17k model count with 14k+ (the shipped dataset has 16,948 models) and left a third spot reading ~17k, so the docs contradicted themselves. All three now say ~17k. The nested-repeat guard test audited filter_map(&:regex), but production compiles strip_separators(regex_strict || regex) — 427 series have a strict variant the test never exercised. It now audits the same source production uses. Also: the warning fires on every Ruby since 3.1, not only Ruby 4, so the comments stop claiming otherwise; and the assertion is restructured so it adds no new RuboCop offense on top of the file's pre-existing baseline. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_015jjKjr2ajZ4etdoMN6eC6k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bundle exec rake test: 192 tests, 211,038 assertions, 0 failures/errors/skips