Repository navigation
otherLabel: a translatable "Other / not listed" (inside 0.2.0, unpublished) - #6
Merged
Merged
Conversation
"Other / not listed" was the one English string the widget hard-coded, shown on make, model and year (and as the combobox's Other row). The new `otherLabel` option (default "Other / not listed") sets that text; the option value stays "other", the API contract every payload reports. Unpublished 0.2.0, so it rides in that release: no version bump, one CHANGELOG line under 0.2.0. Documented in README next to includeOther, shown in the demo. Two tests: default and custom label on all three selects with the value unchanged, and the combobox row. npm test 32 -> 34. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one English string the widget hard-coded.
otherLabel(default unchanged) applies to make, model, year and the search box's Other row; the option VALUE stays"other". Rides inside the unpublished 0.2.0 (CHANGELOG line, no version bump). 34 tests green. The website's embed page passes it in ten languages once its CDN pin reaches 0.2.0.🤖 Generated with Claude Code