Repository navigation
Add CI (build, test, clippy) and fix pre-existing clippy warnings - #2
Merged
Merged
Conversation
… warnings This repo had zero CI. The 25 tests covering the Only-Lang parser, the signed governance chain, and the conductor's UDP-to-rule-engine wiring (merged in #1) only ran when someone remembered to run them locally. - .github/workflows/rust.yml: cargo build/test on push and PR to main, clippy as a hard gate (-D warnings), cargo fmt as report-only. - Fixed the 6 pre-existing clippy warnings so clippy could actually be a hard gate from day one instead of starting pre-broken: two unused imports in pchi-schema/src/lib.rs (DateTime/Utc, thiserror::Error), a manual range-contains in validation.rs, SinkExt/StreamExt each imported but only one used in transport.rs/web_server.rs, and a redundant single-component `use tracing_subscriber;` in main.rs. - cargo fmt --check found 116 pre-existing diff hunks (all whitespace) — a repo-wide reformat is a separate, dedicated change, not something to fold into a CI PR, so fmt stays report-only until that happens separately. Verified locally: cargo build --workspace, cargo clippy --workspace --all-targets -- -D warnings (clean), cargo test --workspace (25 passed). Co-Authored-By: Claude Sonnet 5 <[email protected]>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repo had no CI. The 25 tests merged in #1 (Only-Lang parser, signed governance chain, conductor UDP wiring) only ran when someone remembered to run them locally — a regression there would ship silently.
.github/workflows/rust.yml:cargo build/cargo teston push and PR tomain;clippy -D warningsas a hard gate;cargo fmt --checkas report-only (see below for why).pchi-schema/src/lib.rs, a manual range-contains invalidation.rs, one half of a two-itemuseunused in each oftransport.rs/web_server.rs, and a redundantuse tracing_subscriber;inmain.rs.Why
cargo fmtis report-only, not a gatecargo fmt --all -- --checkfound 116 pre-existing diff hunks, all whitespace, across the whole codebase. Fixing that is a real, separate, dedicated change — reformatting the entire repo doesn't belong bundled into a CI-setup PR where it would swamp the actual diff. Happy to do that as its own PR if wanted.Test plan
cargo build --workspace— cleancargo clippy --workspace --all-targets -- -D warnings— clean (was 6 warnings before this PR)cargo test --workspace— 25 passed, 0 failed🤖 Generated with Claude Code