feat: add log-oriented console writer - #169
Open
Solaris-star wants to merge 1 commit into
Open
Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Progress bars rendered in Kubernetes, Argo, Docker, and other log-oriented environments currently include terminal cursor-control behavior, which makes captured logs incomplete or difficult to read.
Solution
Add
NewLogWriter, aConsoleWriterimplementation that buffers each rendered frame and appends it to the suppliedio.Writerwithout cursor-control sequences or overwriting previous output. Callers can combine it withWithConsoleWriterandWithWidthfor stable log output.Testing
go test ./...ReaderFrominput, flushing, non-terminal detection, and prevention of duplicate output on an empty flush.Relates to #157