Publish via npm trusted publishing; fix contributors metadata - #2
Merged
Merged
Conversation
The @variablelab/portless package now trusts the release.yml workflow in the Release environment, so the publish job exchanges its GitHub OIDC token for a short-lived npm token. Drop the NODE_AUTH_TOKEN env from the publish step, which makes it identical to upstream's again, and describe the setup and the token revocation in docs/RELEASING.md. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01KVTfcx388VGYh1ecW9b7BJ
npm parses a parenthesized part of a person's name as the url, so "Ricardo (rcrd)" was published with url "rcrd" and the real url dropped. Use a plain name and the GitHub profile url. Metadata only; no release. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01KVTfcx388VGYh1ecW9b7BJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci: publish with npm trusted publishing: the package on npm now trustsrelease.ymlin theReleaseenvironment, so the publish job authenticates via GitHub OIDC. TheNODE_AUTH_TOKENenv is removed and the publish step is identical to upstream again.docs/RELEASING.mddocuments the setup and when to revoke the old token.chore: fix contributors entry so npm keeps the url: npm parsed the parenthesized "(rcrd)" as the url; use a plain name and the GitHub profile url.No version bump, so merging does not publish. The OIDC path gets exercised by the next real release.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KVTfcx388VGYh1ecW9b7BJ