Skip to content

Update on HA integration and some suggestions for the API #4

Description

@rrooggiieerr

Hi! I thought you might be interested in the status of the HA integration so attached you'll find some screenshots. The pull request which I created yesterday is required to make the integration work. So when that's incorporated I can release the integration.

It's not entirely clear to me how the data groups work. Can you elaborate?

Also some thing I notices in your API which could use some fine tuning:
The function data_threshold expects the value to be in milliamperes while record_intensity_threshold in the UMmeterData object is converted to amperes.

In my opinion the keys record_capacity_threshold, record_energy_threshold and record_intensity_threshold don't really cover the purpose. I think recorded_capacity, recorded_energy and recording_treshold would be better fitting. What do you think?

Screenshot 2022-12-15 at 17 50 50

Screenshot 2022-12-15 at 17 51 01

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions