[SC-17022] Document risk tiering workflow integration - #1472
Conversation
Adds a new guide page for setting up risk tiering workflows — governance stages, publish/manual triggers, stage-change steps, tier-based branching, and how governance runs behave — and threads the new workflow target through the shared workflow includes (add-new-workflows, workflow-step-types, workflow-states) and the existing risk-tiering pages. Documents backend#3347 / frontend#2714 (merged 2026-08-07). Feature is flag-gated (risk-tier-engine.workflows, subordinate to risk-tier-engine); docs follow the existing convention of not mentioning flags.
|
|
|
Really nice piece of work — I went through this claim by claim against Two things in the new page are worth fixing before this goes out, and both are a sentence each. The rest is minor or already on your radar. The stage-deletion callout promises a safeguard that doesn't existWorth fixing before merge. An admin who follows this page can delete a stage a workflow step depends on, and the review will then silently stop advancing. The callout at The platform only refuses the delete when an assessment or template is currently sitting in that stage — it never looks at workflow steps. The suggested remedy also doesn't help in the case that genuinely is blocked: unhooking the step won't let you delete a stage an assessment currently occupies, and the page offers no way out of that one. Fix: state the real rule — a stage can't be deleted while an assessment or template is currently in it, and deleting a stage a workflow step still references is allowed and will quietly break that step, so update the step first. Following the page produces a workflow that never runsWorth fixing before merge. A reader who follows this page end to end builds a governance workflow that never fires, with nothing to tell them why. "Add a risk tiering workflow" ends at Save Draft ( A draft workflow starts nothing. A manual start comes back with "Cannot start a draft workflow" ( Fix: after "Configure risk tiering steps", add a line pointing at Publish workflow and say plainly that a draft workflow never starts. Regenerating the chatbot map quietly dropped a page from three routesNon-blocking, and not really yours to solve. Someone asking the in-app assistant about record stages while sitting on the Workflows settings page has just lost the canonical how-to from the assistant's context. The regenerated
Fix: nothing needed here beyond deciding whether you're happy with the trade. The generator is the real fix and is worth tracking separately. Prerequisites miss the permission the stages half of the page needsNon-blocking, one bullet. A reader with workflow rights but not template rights won't see Risk Tier Stages in the sidebar at all, and the page gives them nothing to go on. The prerequisites at Fix: add a second prerequisite bullet, phrased the way Archived versions are terminal for governance, and the page doesn't say soNon-blocking. A reader is likely to try restarting a review on the version that was just displaced, and get refused. The page explains that republishing archives the previous version and aborts its runs, then says a manual review "can be re-run on demand" ( Fix: one clause in "How governance runs behave" — once a version is archived it's terminal for governance, and a re-run happens on the current version, not the displaced one. The Workflow Target selectorNon-blocking, and predates this PR — you already flagged it. Just to confirm your read: there's no Workflow Target selector in the UI at all any more. Settings → Workflows is three tabs with per-tab buttons — Add Workflow, Add Artifact Workflow, Add Risk Tiering Workflow ( On the things you asked aboutFeature-flag stance — I'd ship it. The precedent you're leaning on is real: the four existing risk-tiering guide pages are already on Governance-run semantics — accurate as written. I checked each claim separately: the one-run-per-published-version binding, the abort-on-republish wording, approval never changing status, and rejection ending the run all match the merged behaviour. The two gaps in that area are the publish step and the archived-is-terminal point above — nothing in it is stated wrongly. One for the product side, not this PRThe behaviour behind the first comment is worth a ticket on its own. Stage deletion checks only assessments and templates currently in the stage, never the workflow steps that reference it, and the resulting dangling reference fails closed at run time with only a log line to show for it. Either the dependency check should include referencing workflow steps, or the failure should surface on the execution instead of being swallowed. The docs change above just describes today's behaviour accurately — this is the behaviour worth changing. Also minor and entirely optional: |
juanmleng
left a comment
There was a problem hiding this comment.
Really great job @kam-validmind ! thanks so much for taking this PR. I just left a couple of items to look at, other than that, is good to go!
Validate docs site✓ INFO: A live preview of the docs site is available — Open the preview |
Lighthouse check results✓ INFO: Average accessibility score is 0.92 (required: ≥0.9) — View the workflow run Audit mode: changed pages (4 URL(s)) Show Lighthouse scoresCommit SHA: 5a66c08 For a thorough audit, run the Lighthouse check workflow manually (Actions → Lighthouse check → Run workflow) with depth 0–2, or add the
|
Pull Request Description
What and why?
Documents the risk tiering workflow integration shipped in SC-17022 (validmind/backend#3347 + validmind/frontend#2714, merged 2026-08-07). The story carries the
needs-docslabel; nothing in the docs covered any of it before this PR.Before: The risk tiering guides covered templates, calculation, and assessments only. The workflows guide had no mention of risk tiering — no Risk Tiering workflow target, no stage-change steps, no governance stages.
After:
Manually/On Risk Assessment Published/On Risk Tier Template Publishedstart modes, the one-publish-triggered-workflow-per-scope rule), configuring stage-change steps and branching on the assessed risk tier, the stage badge + Active Workflows rail, and the governance-run model (one run per published version; rejection ends the run; republishing aborts prior runs and starts a fresh review; approval never publishes — a person does)._workflow-step-types.qmd): adds Risk Assessment Stage Change and Risk Tier Template Stage Change step reference sections (HTML + RevealJS variants), placed between Artifact Status Change and Workflow State Change to match the builder's step order._add-new-workflows.qmd): adds the Risk Tiering target and an "Add risk tiering workflows" tab (HTML + RevealJS variants)._workflow-states.qmd): adds the Risk Tiering Workflows tab to the three tab lists.All UI labels, step names, trigger names, and constraints were verified against the merged frontend/backend code on
main(not just the PR descriptions) — including the post-merge correction that displaced runs end as aborted (the separatesupersededstatus was removed).How to test
Rendered locally, one page per invocation via the bundled helper:
All eight pages render cleanly; the only warning (
validmind/validmind.qmd) is pre-existing site chrome from_quarto.yml, present on unmodified pages too. New anchors (#risk-assessment-stage-change,#risk-tier-template-stage-change,#define-governance-stages,#add-a-risk-tiering-workflow) verified in the rendered HTML.git diff --checkclean.Preview links (after the
validatedeploy finishes):What needs special review?
launchdarkly.rollout.risk-tier-engine.workflows(subordinate torisk-tier-engine), off by default. Following the existing risk-tiering docs convention, the pages do not mention flags — the new page's prerequisites say "Risk tiering enabled for your organization". Confirm this should merge now vs. being held for the flag rollout._add-new-workflows.qmdinclude still describes a "Workflow Target" selector for record/artifact workflows while the current UI uses tabs; that predates this story and was left as-is (flagging for a separate cleanup).Dependencies, breaking changes, and deployment notes
Release notes
Added documentation for risk tiering workflows: define governance stages, start reviews automatically when an assessment or template is published (or on demand), move stages with dedicated workflow steps, branch on the assessed risk tier, and track review progress on the assessment and template pages. Learn more ...
Checklist