Skip to content

fix: stop exporting Spring Framework from the Spring module (#408) (CP: 5.0) - #419

Open
vaadin-bot wants to merge 1 commit into
5.0from
cherry-pick-408-to-5.0-1790681645251
Open

vaadin-bot wants to merge 1 commit into
5.0from
cherry-pick-408-to-5.0-1790681645251

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #408 to branch 5.0.

Original PR description

Summary

The plain Spring module no longer pulls in Spring Framework (spring-context) for the application. The application now declares Spring itself, so the application decides the Spring version, not the kit.

What changed

Behavior change: spring-context is now an optional dependency in observability-kit-spring, so it no longer comes in through the kit. This affects plain Spring apps (without Spring Boot) that use observability-kit-spring and got spring-context only through the kit. These apps must now declare spring-context themselves (plus spring-web for the HTTP observation hooks), best with org.springframework:spring-framework-bom imported.

🤖 Generated with Claude Code

Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
Co-authored-by: Artur Signell <[email protected]>
Co-authored-by: Giovanni Lovato <[email protected]>
@Artur-

Artur- commented Sep 29, 2026

Copy link
Copy Markdown
Member

I don't think this should be in 5.0

@Artur-

Artur- commented Sep 29, 2026

Copy link
Copy Markdown
Member

Or maybe this one can be - the overall change with Spring dependencies should not go into 25.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants