chore: run native smoke test against the pull request sources - #414
Merged
Merged
Conversation
Install the shared test base and the observability-kit-tests parent POM from the checked out sources, so the smoke test step no longer resolves them from a published snapshot. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Artur-
approved these changes
Sep 25, 2026
Artur-
marked this pull request as ready for review
September 25, 2026 16:54
Artur-
enabled auto-merge (squash)
September 25, 2026 16:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The native smoke test workflow now installs the shared test base and its parent POM from the checked-out code. Before this change, the workflow downloaded them as a published snapshot, so it did not test the pull request's own changes to them.
What changed
Only the CI workflow changed (
.github/workflows/native-smoke.yml). No library code changed, and the change has no effect on users.observability-kit-tests/observability-kit-tests-common. With-am, Maven also installs its parent, theobservability-kit-testsPOM. Both now come from the local sources.-DskipITs. It was only there to keep theobservability-kit-testsbuild out.-DskipTestsstill skips all tests.observability-kit-tests-starter. It gets the shared test base from the local repository that the previous step filled.