Conversation
Artur-
enabled auto-merge (squash)
September 25, 2026 16:45
Vaadin 25.4 no longer brings spring-web in transitively through vaadin-spring, so the starter failed to compile against SpringResyncDetectionFilter (a OncePerRequestFilter). Co-Authored-By: Claude Opus 5.5 <[email protected]>
Member
Author
|
We should make it 25.4 instead |
Align the kit version with the Vaadin version it targets. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
totally-not-ai
Bot
changed the title
Contributor
|
@Artur- Done. The project version is now |
heruan
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the kit to Vaadin Flow 25.4. It also changes the kit version to 25.4-SNAPSHOT, so the kit version now matches the Vaadin version it targets.
What changed
Behavior change: The project version changes from
5.0-SNAPSHOTto25.4-SNAPSHOT. Anyone who depends onobservability-kit-starter,observability-kit-springorobservability-kit-micrometermust update the version in their build. The PR snapshot builds from the workflow now use the25.4.<branch>-SNAPSHOTpattern instead of5.0.<branch>-SNAPSHOT.flow.versiongoes from25.3-SNAPSHOTto25.4-SNAPSHOT.spring-webas a direct dependency. Vaadin 25.4 no longer brings it in throughvaadin-spring, so without it the starter did not compile. (SpringResyncDetectionFilterextendsOncePerRequestFilter, which is inspring-web.) Apps that use the starter getspring-webjust as they did before.