Repository navigation
Public names for the 2/3 mask and the rFFT Parseval weights - #70
Open
rogeriojorge wants to merge 1 commit into
Open
rogeriojorge wants to merge 1 commit into
rogeriojorge wants to merge 1 commit into
Conversation
twothirds_mask and rfft_weights alias the internal functions so companion codes and user diagnostics need not import private names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #9 (base
agent/fix-odd-rfft-energy, which adds_rfft_weights); no CI runs on a stacked base, tests were run locally.Companion codes such as Dark-SPECTRAX import
spectrax._diagnostics._rfft_weightsandspectrax._simulation._twothirds_mask. This PR adds the public aliasesspectrax.rfft_weightsandspectrax.twothirds_mask, which are the same function objects, plus a test. There is no behaviour change.Tests:
pytest -n 2 testsgives 31 passed.