Repository navigation
Support custom midpoint inner products - #30
Closed
rogeriojorge wants to merge 1 commit into
Closed
rogeriojorge wants to merge 1 commit into
rogeriojorge wants to merge 1 commit into
Conversation
rogeriojorge
marked this pull request as ready for review
July 13, 2026 14:59
rogeriojorge
force-pushed
the
agent/midpoint-solver-diagnostics
branch
from
July 16, 2026 14:13
afc5e4b to
e97d9b3
Compare
rogeriojorge
force-pushed
the
agent/midpoint-custom-inner-product
branch
from
July 16, 2026 14:13
8cf6fd0 to
e42f3b8
Compare
Member
Author
|
Dropped: no caller in SPECTRAX needs a custom inner product; #21 keeps the default reductions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inner_productfield toImplicitMidpointWhy
Mapped Hermite/species states require global scalar products. Without a global
reduction, replicas can make different Newton or GMRES stopping decisions and
enter incompatible collective sequences. Keeping the callable on the solver
also supports weighted norms without coupling the solver to a mesh topology.
The mapped simulation will inject its existing species/phase-space scalar
products in a separate PR after the sharding and midpoint stacks share a base.
Validation
8 passedgit diff --checkpassmidpoint trajectories agree; omitting the global product reproduces divergent
collective control flow under Hermite sharding
trajectories agree to
3.45e-25relative L2 inCk; two GPUs give 2.20x speedupStack
This draft targets
agent/midpoint-solver-diagnostics(#29), so the sourcechange is only three lines in
midpoint_solver.pyplus one focused regressiontest.