Repository navigation
Add opt-in regular harmonics for Boozer interpolation - #178
Open
rogeriojorge wants to merge 2 commits into
Open
rogeriojorge wants to merge 2 commits into
rogeriojorge wants to merge 2 commits into
Conversation
rogeriojorge
marked this pull request as ready for review
October 20, 2026 14:19
rogeriojorge
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact samples of
B=8+r^5*cos(5*theta)currently produce a spurious axis derivative. Add opt-inaxis_regular=True: spline each harmonic divided byr^mins, then restore its radial power. Samples and default interpolation are preserved.A required positive tolerance checks inner-profile consistency. This checks interpolation inputs, not equilibrium accuracy. The archived stellarator spectrum fails the 1% check; it remains unqualified.
Validation: 13 tests pass, covering analytic derivatives, axis JIT/AD, sample preservation, input rejection, refinement, and default sine/table interpolation. Lint passes. Full CI is running on the updated head.