Disable NIC checksum, LSO, and VLAN tags - #113
Merged
Merged
Conversation
Gaming Ethernet tune already killed EEE/IM/flow/WoL. Also turn off checksum/LSO and Priority/VLAN. RSS stays on. Do not force Speed/Duplex.
There was a problem hiding this comment.
🟡 Changes recommended
The NIC tuning script introduces unprofessional wording in a newly added comment that should be made neutral/public-kit appropriate.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates Reclaim11’s NIC tuning to additionally disable checksum offloads, LSO, and VLAN/priority tagging while keeping RSS enabled and preserving the existing RX/TX buffer “CS2 band” behavior.
Changes:
- Extend
nic_tune.ps1keyword disable-map to include checksum offloads, LSO, and Packet Priority & VLAN (and a couple of related adapter power/latency knobs). - Strengthen
Test-Reclaim11.ps1to assert offloads/LSO/VLAN are disabled and Speed/Duplex is not forced. - Refresh UI and README wording to reflect the expanded NIC tuning behavior.
File summaries
| File | Description |
|---|---|
| scripts/Test-Reclaim11.ps1 | Adds assertions that NIC tuning disables checksum offload, LSO, and VLAN/priority, and does not force Speed/Duplex. |
| godbrain_core/reclaim11/ui/MainWindow.xaml | Updates the NIC tuning label text to reflect “offloads off, RSS on”. |
| godbrain_core/reclaim11/README.md | Updates Tune NIC description to include offloads/LSO/VLAN-priority and “does not force Speed/Duplex”. |
| godbrain_core/reclaim11/ps1/nic_tune.ps1 | Expands the disable keyword set for NIC tuning to cover checksum offloads/LSO/VLAN tagging and related settings. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tune NIC now also disables TCP/UDP/IP checksum offload, LSO, and Packet Priority & VLAN. RSS stays on. Rx/Tx stay 256–512. Speed/Duplex is not forced (host 1G lock is not the public kit).
Restore.json first. Ethernet only. Not CS2. Not the kernel.