Repository navigation
Clamp fleet dispatch concurrency to at least one - #377
Merged
abhishekgahlot2 merged 1 commit intoOct 26, 2026
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
Hi @abhishekgahlot2, could you review my fix for the dispatch freeze when you have a moment? CI is still waiting for approval, so I'd appreciate your help with that too. |
Contributor
|
Merged, thanks @gezerui888! Nice touch running the real dispatch loop in the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By opening this pull request you agree to the Contributor License Agreement. On your first pull request a bot asks you to sign it with a one-line comment.
Fixes #314.
I clamped
maxDispatchConcurrencyto at least 1 after integer parsing. This prevents0and0.5from freezing reconciliation when a task is queued. Other fleet settings keep their existing behavior.I added regression tests for both values with a queued task. They check the config before reconciliation, so the old code fails without hanging the suite.
Tests:
bun run typecheckbun test scripts/agent-docs.test.tscd backend && bun run testcd frontend && bun run test && bun run lintPOST /api/runs. Before the fix, subsequent health requests timed out. After the fix, health and run requests returned HTTP 200.Screenshots / Recordings
Before
After
Need help on this PR? Tag
@codesmith-botwith what you need.