Repository navigation
Clamp fleet dispatch concurrency to at least one - #377
Open
gezerui888 wants to merge 1 commit into
Open
gezerui888 wants to merge 1 commit into
gezerui888 wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By opening this pull request you agree to the Contributor License Agreement. On your first pull request a bot asks you to sign it with a one-line comment.
Fixes #314.
I clamped
maxDispatchConcurrencyto at least 1 after integer parsing. This prevents0and0.5from freezing reconciliation when a task is queued. Other fleet settings keep their existing behavior.I added regression tests for both values with a queued task. They check the config before reconciliation, so the old code fails without hanging the suite.
Tests:
bun run typecheckbun test scripts/agent-docs.test.tscd backend && bun run testcd frontend && bun run test && bun run lintPOST /api/runs. Before the fix, subsequent health requests timed out. After the fix, health and run requests returned HTTP 200.Screenshots / Recordings
Before
After
Need help on this PR? Tag
@codesmith-botwith what you need.