feat(network): add support for forward guest localhost DNS for unikraft - #966
Draft
alimx07 wants to merge 2 commits into
Draft
feat(network): add support for forward guest localhost DNS for unikraft#966alimx07 wants to merge 2 commits into
alimx07 wants to merge 2 commits into
Conversation
…dcoded 8.8.8.8 Adds NetDevParams.DNSServer so the network manager can pass a resolver IP (e.g. from localhost DNS forwarding) through to the Unikraft netdev cmdline. Falls back to 8.8.8.8 when unset, preserving current behavior.
✅ Deploy Preview for urunc canceled.
|
alimx07
changed the title
Contributor
|
However, please complete the PR description correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will add support for localhost semantics added in #793 for unikraft unikernels. This will be done by modifying the CMD line defined here:
as the new DNSServer will be either:
internal/constants/network_constants(e.g. 192.168.100.100)The exact of this happens is defined in #793 but as breif, we detect if we have localhost resolvers ,then rewrite them to point to our Custom resolver, where we apply
TC rulesto intercept traffic and redirect it according to our rulesRelated issues
How was this tested?
LLM usage
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).