pkg/unikontainers: unmask underlying errors in checkValidNsPath - #965
Open
srinivasr wants to merge 2 commits into
Open
pkg/unikontainers: unmask underlying errors in checkValidNsPath#965srinivasr wants to merge 2 commits into
srinivasr wants to merge 2 commits into
Conversation
checkValidNsPath previously caught all os.Lstat errors and returned ErrNotExistingNS. this masked permission-denied and I/O errors behind a generic missing-namespace error. check for os.IsNotExist(err) specifically. wrap and return all other errors to the caller. Fixes: urunc-dev#890 Signed-off-by: B Srinivas Reddy <[email protected]>
✅ Deploy Preview for urunc canceled.
|
Add unit tests covering missing, empty, valid, comma-containing, and permission-denied namespace paths for checkValidNsPath. Also validate comma separation prior to lstat. Signed-off-by: B Srinivas Reddy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
checkValidNsPath previously caught all os.Lstat errors and returned ErrNotExistingNS. this masked permission-denied and I/O errors behind a generic missing-namespace error.
check for os.IsNotExist(err) specifically. wrap and return all other errors to the caller.
Related issues
How was this tested?
ran
make unittestlocally.verified the
ErrNotExistingNSsentinel is preserved for expected missing namespace scenarios (e.g.Kill()behavior).LLM usage
I used Gemini 3.1 Pro to help debug the namespace path checks. The final patch and testing were completed entirely by me.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).