ci: Remove dead code, unused inputs and honor input refs - #941
Open
cmainas wants to merge 2 commits into
Open
Conversation
- Delete unused typos.toml (spell-check runs cspell, not typos). - Remove useless "Get revision SHA" steps and inline github.ref_name where the branch value is still needed (build-latest). - Remove the dead "Get image digest" and "Set short SHA" steps in build-latest. - Drop unused workflow inputs (runner, runner-arch-map, unused runner-archs, dead ref) and their call-site passes - Use the declared ref input into checkout (lint, unit_test, vm_test, kind_test) - Remove unused GIT_CLONE_PAT secret and no-op workflow_dispatch triggers that cannot run standalone (upload_s3, vm_test, kind_test) - Drop redundant host dependency install in kind_test (used only inside the node) Signed-off-by: Charalampos Mainas <[email protected]>
✅ Deploy Preview for urunc canceled.
|
cmainas
force-pushed
the
fix/small_fixe_ci
branch
from
August 10, 2026 17:59
ab7669a to
e016a36
Compare
cmainas
marked this pull request as ready for review
August 10, 2026 18:13
We currently execute the end-to-end tests using the base ref of a PR in order to ensure that the PR's code works as expected and nothing in the PR trickes the tests in order to succeed. However, we also need to tests the changes that take place in the e2e tests. For that reason, another run of vm_tests is triggered using the PR's branch ref to check if the new code of end-to-end tests is working properly. Signed-off-by: Charalampos Mainas <[email protected]>
cmainas
force-pushed
the
fix/small_fixe_ci
branch
4 times, most recently
from
August 19, 2026 10:50
e016a36 to
bafe00f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Edit: A new job has been added which executes the e2e vm_test when something changes in e2e using the PR's branch ref to checkout the code. Otherwise the base branch of the PR is used as a checkout ref, keeping the base testing code stable across new PRs.
Related issues
How was this tested?
In PR's CI
LLM usage
Assisted by Opus 4.8
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).