Repository navigation
Return destination write errors from rendering engines - #115
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
The buffered engines currently report success when a destination write fails. For example, rendering a body with HTTP 204 hides Go's
http.ErrBodyNotAllowed.Return destination errors from every engine and stop later engine writes after a failure. Streaming JSON also returns a failed prefix write before encoding.
Tests cover each output stage, including partial writes and exact successful output. Real HTTP 204 cases verify the returned error with
DisableHTTPErrorRenderingenabled.make cipasses on Go 1.25.0.make testpasses on Go 1.26.0, including configured lint, race tests and vet. Both package builds pass. All 139 new cases pass, and 95 regressions fail on unchanged v1.