Repository navigation
Reset pending requests when moving GraphemeCursor - #186
Merged
Manishearth merged 1 commit intoOct 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
s = "abcd", seeking to2while a chunk request is pending makes bothnext_boundary(s, 0)andprev_boundary(s, 0)returnOk(Some(2)). The documented forward search starts after the current position, so it should return3, and the previous boundary is1.We clear the pending movement and pre-context state when the cursor changes position and document the cancellation behavior. A regression test covers all three input requests in both segmentation modes, and the full test suite passes.
Checkout: e77d186
— ChipLab