Repository navigation
Fix CI package test step on newer cargo - #15
Merged
Merged
Conversation
Newer cargo leaves target/package/tmp-crate/ behind after `cargo package`, so the `find` used to locate the unpacked crate returned two directories and `cd` failed with "too many arguments". Select the directory by package name instead. The trailing slash makes the glob match directories only, so neither tmp-crate nor the .crate file is picked up.
Merged
Manishearth
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Test packagestep fails on current stable (seen in #14):The
findassumestarget/package/contains exactly one directory. Newer cargo also leavestarget/package/tmp-crate/behind aftercargo package, so two directories are returned andcdfails. This is unrelated to the changes in #14. CI simply had not run since November 2025, so the breakage went unnoticed.Reproduced locally:
target/package/unicode-properties-0.1.4unicode-properties-0.1.4,tmp-crateFix
Select the unpacked crate by package name in both
Test packageandTest package without features:The trailing slash makes the glob match directories only, so neither
tmp-cratenor the.cratefile is picked up.Testing
Ran both commands locally with cargo 1.95.0 while
tmp-crate/was present. Both pass.